[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser
Owen Pan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 7 21:20:19 PST 2022
This revision was not accepted when it landed; it landed in state "Needs Revision".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd97025ad3a70: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser (authored by owenpan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116318/new/
https://reviews.llvm.org/D116318
Files:
clang/lib/Format/UnwrappedLineParser.cpp
Index: clang/lib/Format/UnwrappedLineParser.cpp
===================================================================
--- clang/lib/Format/UnwrappedLineParser.cpp
+++ clang/lib/Format/UnwrappedLineParser.cpp
@@ -32,7 +32,7 @@
// Returns the next token in the token stream.
virtual FormatToken *getNextToken() = 0;
- // Returns the token precedint the token returned by the last call to
+ // Returns the token preceding the token returned by the last call to
// getNextToken() in the token stream, or nullptr if no such token exists.
virtual FormatToken *getPreviousToken() = 0;
@@ -246,8 +246,7 @@
}
FormatToken *getPreviousToken() override {
- assert(Position > 0);
- return Tokens[Position - 1];
+ return Position > 0 ? Tokens[Position - 1] : nullptr;
}
FormatToken *peekNextToken() override {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116318.398297.patch
Type: text/x-patch
Size: 837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220108/dfd01f20/attachment.bin>
More information about the cfe-commits
mailing list