[PATCH] D115183: [clang][HeaderSearch] Support framework includes in suggestPath...

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 7 15:19:26 PST 2022


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1955
+  bool IsPrivateHeader;
+  SmallString<128> FrameworkName, IncludeSpelling;
+  if (BestPrefixIsFramework &&
----------------
nit: I don't think these strings need to be so big, framework includes are a fairly uncommon case probably?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115183/new/

https://reviews.llvm.org/D115183



More information about the cfe-commits mailing list