[PATCH] D116827: Don't pass uninitialized QueryKind

Vitaly Buka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 7 15:12:49 PST 2022


vitalybuka added a comment.

In D116827#3228594 <https://reviews.llvm.org/D116827#3228594>, @vitalybuka wrote:

> In D116827#3228524 <https://reviews.llvm.org/D116827#3228524>, @kda wrote:
>
>> This seems to introduce a new branch, should there be a new unit test in: XRefsTests.cpp?
>
> It's not functional change, test should not be able to see a difference after this patch.

to clarify: it's not realy new branch, as findImplementors already does exactly the same check.
I considered removing that check, but it will complicated other callers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116827/new/

https://reviews.llvm.org/D116827



More information about the cfe-commits mailing list