[PATCH] D116827: Don't pass uninitialized QueryKind

Kevin Athey via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 7 14:22:23 PST 2022


kda added a comment.

This seems to introduce a new branch, should there be a new unit test in: XRefsTests.cpp?



================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1313
   }
+  if (IDs.empty())
+    return {};
----------------
It seems like the first line of 'findImplementors' is 'if (IDs.empty() || !Index)`.
I wonder if the correct fix is to drop the '!Index' check in findImplementors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116827/new/

https://reviews.llvm.org/D116827



More information about the cfe-commits mailing list