[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

Fri Jan 7 01:50:49 PST 2022

pengfei added a comment.

In D115942#3226146 <https://reviews.llvm.org/D115942#3226146>, @rnk wrote:

> Yeah, let's try to reach some resolution on that.

The things are different. We don't support f80 type on Windows 32 bits previously. It means we don't have the burden to upgrade, since there's no global/load/store/GEP/etc for f80.

> In the mean time, I discovered the `alignstack` parameter attribute:
> https://llvm.org/docs/LangRef.html#parameter-attributes
>
> Could that be used to solve this problem in the frontend instead?

It might be feasible, but I don't think it's a good idea. It looks to me more like a language specific alignment hint instead of medium that carrying target specific information.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115942/new/

https://reviews.llvm.org/D115942