[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

[Marek Kurdej via Phabricator via cfe-commits]

curdeius added a comment.

Thanks for the reviews!



================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1528
         // for them (the one we know is missing are lambdas).
-        if (Style.BraceWrapping.AfterFunction)
+        if ((Style.Language == FormatStyle::LK_Java) &&
+            Line->Tokens.front().Tok->is(Keywords.kw_synchronized)) {
----------------
owenpan wrote:
> Remove redundant parens.
I don't think they're redundant because of 2 reasons: nested if and comment inside.
Cf. https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1535
+            addUnwrappedLine();
+        } else if (Style.BraceWrapping.AfterFunction)
           addUnwrappedLine();
----------------
owenpan wrote:
> Add braces to "keep it uniform" with the `if` block.
Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116767/new/

https://reviews.llvm.org/D116767