[PATCH] D116059: [Clang][CFG] check children statements of asm goto

Thu Jan 6 15:59:37 PST 2022

efriedma accepted this revision.
efriedma added a comment.

LGTM

================
Comment at: clang/test/Analysis/uninit-asm-goto.cpp:84
+
+int test8() {
+    int x = 0; // expected-warning {{variable 'x' is used uninitialized whenever its declaration is reached}}
----------------
Looks like this patch fixes the false negative on test8; that's good.

It looks like there's a issue with the printed diagnostic on a bunch of these tests; we say the variable is used uninitialized "whenever its declaration is reached", which isn't right.  We can probably leave that for a followup; this is clearly an improvement.  But please file a bug.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116059/new/

https://reviews.llvm.org/D116059