[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants
Richard via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 6 14:37:15 PST 2022
LegalizeAdulthood added a comment.
Also, re-reading the C++ guidelines, I agree that this check is handling the two cases
ES.31 (Don't use macros for constants and functions)
ES.33 (Don't use macros that aren't all caps)
I guess previously it **technically** handled ES.30 (don't use macros for text manipulation)
by just complaining about every macro not being replaced with a `constexpr` constant,
LOL.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116386/new/
https://reviews.llvm.org/D116386
More information about the cfe-commits
mailing list