[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 6 12:00:23 PST 2022


tra added a comment.

In D114601#3224469 <https://reviews.llvm.org/D114601#3224469>, @mojca wrote:

> In D114601#3223155 <https://reviews.llvm.org/D114601#3223155>, @tra wrote:
>
>> Ping. @mojca, do you need help landing the patch?
>
> Yes, please. I don't have commit access yet.
> You can attribute it to mojca at macports.org, for example.

Will do once we sort out the tests.

> We also need a fix for unit tests on the CI in order to find the files, but I cannot help with that as I don't know how that works.

You may need to adjust `clang/test/Driver/cuda-windows.cu` and possibly the mock CUDA installation under `clang/test/Driver/Inputs/CUDA-windows`.

In D114601#3224485 <https://reviews.llvm.org/D114601#3224485>, @mojca wrote:

> Also, I would like to get to do some further "baby steps" towards better support of CUDA on Windows in particular, but I would need some guidelines.
> I requested a special channel that would allow a bit of discussion https://discord.com/channels/636084430946959380/.
> What would be the best way to shortly discuss the options?

Email would work. cfe-dev@ list would work, too. Chat does not work well for me -- my reply latency tends to be higher than that of email and it's not as good for keeping a record of the conversation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114601/new/

https://reviews.llvm.org/D114601



More information about the cfe-commits mailing list