[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

Thu Jan 6 06:06:09 PST 2022

MyDeveloperDay added a comment.

> (1) very few people use... I don't think it's actually the behavior people will want....

Subjective or Objective opinion?

https://github.com/search?o=desc&q=%22ColumnLimit%3A+0%22&s=indexed&type=Code

95,000+ occurrences of "ColumnLimit" in github YAML files and multiple `ColumnLimit: 0` even on the first page  and https://www.hyrumslaw.com/ suggests we shouldn't make that kind of assumption

>From my recollection @mprobst is the original author of this and they are on this review as a reviewer so I tend to bow to their better judgement. its possible we never thought about the ColumnLimit: 0 case originally.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116638/new/

https://reviews.llvm.org/D116638