[PATCH] D116726: [clang-format] Fix a crash (assertion) in qualifier alignment when matching template closer is null

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 6 04:31:49 PST 2022


MyDeveloperDay updated this revision to Diff 397853.
MyDeveloperDay marked 3 inline comments as done.
MyDeveloperDay added a comment.

Use getNextNonComment() which has some const-ness knock ons (but probably not a bad thing)

address the review concerns by adding more tests (which indeed highlighted new failure scenarios! Thanks @curdeius)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116726/new/

https://reviews.llvm.org/D116726

Files:
  clang/lib/Format/QualifierAlignmentFixer.cpp
  clang/lib/Format/QualifierAlignmentFixer.h
  clang/unittests/Format/QualifierFixerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116726.397853.patch
Type: text/x-patch
Size: 7050 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220106/281e876a/attachment.bin>


More information about the cfe-commits mailing list