[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 6 01:45:33 PST 2022


owenpan added a comment.

In D116316#3224591 <https://reviews.llvm.org/D116316#3224591>, @MyDeveloperDay wrote:

> Owen I think we should push ahead with this rather than D95168: [clang-format] Add Insert/Remove Braces option <https://reviews.llvm.org/D95168> as I've looked at what you've done here I'm reminded that the removal and insertion are likely mutually exclusive operations.
>
> There is no doubt that insertion is desired (so I'd like to see us do that afterwards) but I now think that could be in a completely separate pass as you originally suggested.
>
> LGTM

Thanks! I will wait a couple of days in case other reviewers have some final requests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116316/new/

https://reviews.llvm.org/D116316



More information about the cfe-commits mailing list