[PATCH] D88833: [clang-tidy] Do not warn on pointer decays in system macros

Elvis Stansvik via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 5 10:07:08 PST 2022


estan added a comment.

Sounds good @aaron.ballman, let's wait for @fiesh.

Though I realize now that the scope of this patch is probably not enough to solve a problem we have in our code base. The check will warn about (for example) things like this:

In a third party lib outside our control:

  void f(double out[3]);

In our code:

  double out[3];
  fn_in_third_party_lib(out);

Include paths for the third party lib are added with -isystem.

Am I right that we're still going to get warnings for this with this patch?

Full disclosure. The third party lib is VTK, which is littered with APIs like these.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88833/new/

https://reviews.llvm.org/D88833



More information about the cfe-commits mailing list