[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

[Reid Kleckner via Phabricator via cfe-commits]

rnk accepted this revision.
rnk added a comment.

lgtm



================
Comment at: clang/test/CodeGen/pr52782-stdcall-func-decl.cpp:10
+class nsICanvasRenderingContextInternal {
+  NS_IMETHOD_(nsresult) InitializeWithDrawTarget(NotNull);
+} nsTBaseHashSet;
----------------
rnk wrote:
> Please check for the declaration with the mangled name. In this case, we expect to see a `@0` suffix.
> 
> Also, the `NS_IMETHOD_` macro isn't necessary for the reduction, it can just be `void __stdcall InitializeWithDrawTarget(NotNull)`.
I see, the `@4` suffix is for `this`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116020/new/

https://reviews.llvm.org/D116020