[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 5 07:31:18 PST 2022


ksyx added a comment.

In D116314#3221488 <https://reviews.llvm.org/D116314#3221488>, @MyDeveloperDay wrote:

> @ksyx
>
> Did you see this issue https://github.com/llvm/llvm-project/issues/52976
>
> In its current form, this patch causes huge amounts of flux in projects
> that document code like (anyone using doxygen likely, + most normal people
> ;-) )
>
> ...
> }
>
> // My function
> <<<<--------  extra newline added
> void
> foo()
> {
> }
>
> as it will place and undesirable additional newline between the function
> and the return type.
>
> We really need this to be resolved before we branch out v14 (which may be
> imminent)
>
> MyDeveloperDay

Thanks for the feedback! I have proposed some fix in D116663 <https://reviews.llvm.org/D116663>, and please see if this works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116314/new/

https://reviews.llvm.org/D116314



More information about the cfe-commits mailing list