[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.h:37-48
+  using FunctionExceptionType = llvm::SmallSet<StringRef, 3>;
   AssertSideEffectCheck(StringRef Name, ClangTidyContext *Context);
   void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
   void registerMatchers(ast_matchers::MatchFinder *Finder) override;
   void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
 
 private:
----------------
Instead of using "Exception" here, can we rename slightly? Functions can have lists of exceptions (dynamic exception specifications are a thing in C++), so the use of "exception" can be somewhat confusing, but I think something like `IgnoredFunctionList` and `IgnoredFunctions` would be an improvement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116478/new/

https://reviews.llvm.org/D116478