[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 5 00:48:48 PST 2022
MyDeveloperDay added inline comments.
================
Comment at: clang/unittests/Format/FormatTestJS.cpp:1948
+ Style.JavaScriptWrapImports = false;
verifyFormat("import {VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying,"
" VeryLongImportsAreAnnoying, VeryLongImportsAreAnnoying"
----------------
MyDeveloperDay wrote:
> you are no longer testing the LLVM Case, please don't remove that, but feel free to ensure they are doing the same for google!
Its kind of our golden rule, don't change existing tests, subtle changes can have huge implications on large code bases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116638/new/
https://reviews.llvm.org/D116638
More information about the cfe-commits
mailing list