[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

[Sam Elliott via Phabricator via cfe-commits]

lenary added inline comments.


================
Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6
+// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > %t.dir/build/vfs.yaml
+// RUN: clang-scan-deps -compilation-database %t.dir/build/compile-commands.json -j 1 -format experimental-full \
+// RUN:   -mode preprocess-minimized-sources -generate-modules-path-args > %t.db
+// RUN: %python %S/../../utils/module-deps-to-rsp.py %t.db --module-name=A > %t.A.cc1.rsp
----------------
rsmith wrote:
> There seems to be a problem with this test: it's writing a module cache to the current working directory instead of writing it into somewhere under `%t`. Presumably this just requires adding a module cache path parameter?
I think the easiest fix is to change the `command` string in the json below, to update the passed `-fmodules-cache-path`. I'm working on a patch right now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114206/new/

https://reviews.llvm.org/D114206