[PATCH] D116385: [clangd] Code action for creating an ObjC initializer
David Goldman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 4 10:07:32 PST 2022
dgoldman marked an inline comment as done.
dgoldman added inline comments.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/ObjCMemberwiseInitializer.cpp:91
+
+struct LocationWithPadding {
+ SourceLocation Loc;
----------------
sammccall wrote:
> We try not to spend complexity on formatting beyond what clang-format cares about.
>
> If you're inserting before a member (or @end), always inserting 2 newlines seems close enough? (clang-format will strip consecutive blank lines)
Just went with that for now, can revisit later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116385/new/
https://reviews.llvm.org/D116385
More information about the cfe-commits
mailing list