[PATCH] D111457: [clang][test] Add lit helper for windows paths

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 4 07:56:12 PST 2022


compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/test/lit.cfg.py:60
+if platform.system() == 'Windows':
+    root_sep = 'C:\\'
+else:
----------------
This isn't really a separator, this is the root itself.  I think that it makes sense to name it accordingly.  Please do not hard code this to `C:\`.  There is no guarantee that the root is `C:\`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111457/new/

https://reviews.llvm.org/D111457



More information about the cfe-commits mailing list