[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

[Alexandre Ganea via Phabricator via cfe-commits]

aganea added a subscriber: dblaikie.
aganea added a comment.

I was wondering, can we mandate `LLVM_ENABLE_WERROR=ON` for all bots at least? (or maybe enable it through cmake, if ever there's a setting to detect we're running as a bot)
Or just reverse the default setting on the main branch, ie. make `LLVM_ENABLE_WERROR=ON` by default and let users disable it locally. I think that would encourage users to care more about warnings? Release branches could have it disabled somehow, to accommodate for the changing compiler environments. Was this discussed before?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116313/new/

https://reviews.llvm.org/D116313