[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 3 08:27:23 PST 2022


aganea added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/PDB/DIA/DIASupport.h:34
+#endif
 #include <dia2.h>
+#ifdef __clang__
----------------
hans wrote:
> I thought this warning should be suppressed for system headers. Isn't that working here?
Good point, because it wasn't included as a system header in the first place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116313/new/

https://reviews.llvm.org/D116313



More information about the cfe-commits mailing list