[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

Jeff Niu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 3 08:18:39 PST 2022


Mogball added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp:157
     // will clean this up afterwards.
-    MyDiag << FixItHint::CreateReplacement(
-        RemovalRange, (Twine(" /*") + Param->getName() + "*/").str());
+    if (Options.get("CommentOutUnusedParameters", true))
+      MyDiag << FixItHint::CreateReplacement(
----------------
Oh I was thinking that the option would disable editing the parameter at all. I.e. it would leave unused parameters untouched or remove the parameter from the function signature altogether (if it can).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116488/new/

https://reviews.llvm.org/D116488



More information about the cfe-commits mailing list