[PATCH] D116313: [MSVC] Silence -Wnon-virtual-dtor on DIA APIs

Mon Jan 3 05:51:11 PST 2022

hans added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:54
+#endif
 #include "MSVCSetupApi.h"
+#ifdef __clang__
----------------
Since it's in our repository, would it be possible to fix clang/lib/Driver/ToolChains/MSVCSetupApi.h to be warning free? If it's not possible to fix the classes the warning refers to, I think it would at least be nicer to move the pragma into that file.

================
Comment at: llvm/include/llvm/DebugInfo/PDB/DIA/DIASupport.h:34
+#endif
 #include <dia2.h>
+#ifdef __clang__
----------------
I thought this warning should be suppressed for system headers. Isn't that working here?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116313/new/

https://reviews.llvm.org/D116313