[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

David Majnemer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 2 20:05:33 PST 2022


majnemer added a comment.

This is looking great! Just a few more questions.

What is the behavior with something like:

  thread_local int x = 2;
  int f() {
    return x;
  }

I'm wondering if we need to move this logic <https://github.com/llvm/llvm-project/blob/1f07a4a5699b73582461880e716e6692cbe3d6a6/clang/lib/CodeGen/ItaniumCXXABI.cpp#L391-L392> into the generic C++ ABI implementation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115456/new/

https://reviews.llvm.org/D115456



More information about the cfe-commits mailing list