[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 30 16:04:30 PST 2021


ksyx updated this revision to Diff 396727.
ksyx marked 9 inline comments as done.
ksyx added a comment.

- Apply review suggestions.
- Assert the style is not `SDS_Leave` in private method, while return no change in public method if so.
- Rename loop variable `Line` to `CurrentLine`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116314/new/

https://reviews.llvm.org/D116314

Files:
  clang/docs/ClangFormatStyleOptions.rst
  clang/include/clang/Format/Format.h
  clang/lib/Format/CMakeLists.txt
  clang/lib/Format/DefinitionBlockSeparator.cpp
  clang/lib/Format/DefinitionBlockSeparator.h
  clang/lib/Format/Format.cpp
  clang/lib/Format/WhitespaceManager.cpp
  clang/lib/Format/WhitespaceManager.h
  clang/unittests/Format/CMakeLists.txt
  clang/unittests/Format/DefinitionBlockSeparatorTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116314.396727.patch
Type: text/x-patch
Size: 30286 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211231/ec3836c1/attachment-0001.bin>


More information about the cfe-commits mailing list