[PATCH] D116415: [Arm] Remove duplicate CPU tests

Thu Dec 30 10:06:02 PST 2021

nickdesaulniers accepted this revision.
nickdesaulniers added inline comments.
This revision is now accepted and ready to land.

================
Comment at: clang/test/Driver/arm-cortex-cpus.c:217
 // RUN: %clang -target arm -march=armv8.1-a -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V81A %s
-// RUN: %clang -target arm -march=armv8.1a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V81A %s
 // RUN: %clang -target armv8.1a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V81A %s
----------------
I'm definitely ok with the half of changes in this patch that remove `-mlittle-endian` when it appears twice on one line.

The other half of the changes remove `-mlittle-endian` when it's not specified more than once. I suspect `-mlittle-endian` is implied by `-target` in this case; was the test validating that by being explicit about endianness?  I guess I don't see how being explicit about the endianness could affect the `-triple`, which is what is being checked, so I guess this LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116415/new/

https://reviews.llvm.org/D116415