[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code
Owen Pan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 29 17:07:12 PST 2021
owenpan added inline comments.
================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2303
+ assert(IfRightBrace->MatchingParen == IfLeftBrace);
+ IfLeftBrace->MatchingParen = nullptr;
+ IfRightBrace->MatchingParen = nullptr;
----------------
HazardyKnusperkeks wrote:
> Why null that?
`MatchingParen` is used to flag braces that may be optional. If it turns out that they should not be removed, we must reset it. Otherwise, the test case on line 23314 in FormatTest.cpp below would fail.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116316/new/
https://reviews.llvm.org/D116316
More information about the cfe-commits
mailing list