[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 29 07:04:31 PST 2021


HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2338
+  KeepAncestorBraces();
+  NestedTooDeep.push_back(false);
   if (FormatTok->is(tok::l_brace)) {
----------------
owenpan wrote:
> HazardyKnusperkeks wrote:
> > I think it is worth to create a RAII type for that.
> Can you explain why an RAII type would be beneficial here?
You have a lot of push/pop pairs. There is the risk someone (in the future) may misuse it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116316/new/

https://reviews.llvm.org/D116316



More information about the cfe-commits mailing list