[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

[Marek Kurdej via Phabricator via cfe-commits]

curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.

LGTM but please wait for the green light from other involved reviewers.
Also, as noted in a comment, I'd like to see unrelated changes in a different patch (unless you convince me that it's overly complicated or too much dependent on this patch).



================
Comment at: clang/lib/Format/Format.cpp:3298
+    // Search for parent configs starting from the parent directory of
+    // ConfigFile
+    FileName = ConfigFile;
----------------
Here and elsewhere: please end the comments with a full stop.


================
Comment at: clang/unittests/Format/FormatTest.cpp:21483
 
-  // Test 9.1: overwriting a file style, when parent no file exists with no
+  // Test 9.1.1: overwriting a file style, when parent no file exists with no
   // fallback style
----------------
?


================
Comment at: clang/unittests/Format/FormatTest.cpp:21499
 
+  // Test 9.1.2: propagate more than one level with no parent file
+  ASSERT_TRUE(FS.addFile("/e/sub/sub/code.cpp", 0,
----------------
Can we split changes unrelated to the specific configuration file (fixing/testing the inherited config) to another patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72326/new/

https://reviews.llvm.org/D72326