[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 28 12:48:04 PST 2021


ksyx marked an inline comment as done.
ksyx added inline comments.


================
Comment at: clang/lib/Format/Format.cpp:2114
+      if (Result.add(R))
+        return;
+  }
----------------
HazardyKnusperkeks wrote:
> Why only add the first replacement?
This worked well as the `Error` class `add` method returned has overloaded boolean operator, returning true (nonzero) when failing, which simulates program exit code scheme? (ref: [[ https://llvm.org/doxygen/classllvm_1_1Error.html#a981b4992a3b7cce718c7995a7d6193a0 | Doxygen/Error/operator bool ]])


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116314/new/

https://reviews.llvm.org/D116314



More information about the cfe-commits mailing list