[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments
Adrian Vogelsgesang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 28 09:11:44 PST 2021
avogelsgesang added inline comments.
================
Comment at: clang/lib/Format/TemplateArgumentKeywordFixer.h:36
+} // end namespace format
+} // end namespace clang
+
----------------
avogelsgesang wrote:
> curdeius wrote:
> > Please make the comments consistent with other files.
> Consistent with which other files?
> My comments here are consistent with `NamespaceEndCommentsFixer.h` and `QualifierAlignmentFixer.h` which I used for reference while writing this change
ok, now I understood what you meant...
You meant consistency with the other files in this commit, in particular with the corresponding cpp file `TemplateArgumentKeywordFixer.h`.
Fun fact: I copied this inconsistency from `NamespaceEndCommentsFixer.h`/`.cpp` which also use different comment styles between `.h` and `.cpp`.
I updated my change to consistently use the `// namespace` style
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116290/new/
https://reviews.llvm.org/D116290
More information about the cfe-commits
mailing list