[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

Adrian Vogelsgesang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 28 09:03:15 PST 2021


avogelsgesang updated this revision to Diff 396401.
avogelsgesang marked 7 inline comments as done.
avogelsgesang added a comment.

Thank you for your review, @curdeius!

I updated my change to address most of your comments.
Regarding "KeepTemplateTemplateKW", I think we had a misunderstanding (see replies to inline comments).
Could you take a 2nd look at those comments?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116290/new/

https://reviews.llvm.org/D116290

Files:
  clang/docs/ClangFormatStyleOptions.rst
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Format/Format.h
  clang/lib/Format/CMakeLists.txt
  clang/lib/Format/Format.cpp
  clang/lib/Format/TemplateArgumentKeywordFixer.cpp
  clang/lib/Format/TemplateArgumentKeywordFixer.h
  clang/unittests/Format/CMakeLists.txt
  clang/unittests/Format/TemplateArgumentKeywordFixerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116290.396401.patch
Type: text/x-patch
Size: 25742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211228/d9d816d6/attachment-0001.bin>


More information about the cfe-commits mailing list