[PATCH] D116290: [clang-format] Add enforcement of consistent `class`/typename` keyword for template arguments

Adrian Vogelsgesang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 27 19:17:57 PST 2021


avogelsgesang updated this revision to Diff 396361.
avogelsgesang marked 4 inline comments as done.
avogelsgesang added a comment.

Thank you for the quick review, @HazardyKnusperkeks!

I addressed most of your comments by fixing my code.
In two cases, I think there was a misunderstanding and I didn't apply your proposed changes, yet.
See my inline replies re "assert on non nullness" and "`typename` vs `Typename` in configuration".
If you still think, I should apply your proposed changes, please let me know. I don't have strong opinions on those points and am happy to do so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116290/new/

https://reviews.llvm.org/D116290

Files:
  clang/docs/ClangFormatStyleOptions.rst
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Format/Format.h
  clang/lib/Format/CMakeLists.txt
  clang/lib/Format/Format.cpp
  clang/lib/Format/TemplateArgumentKeywordFixer.cpp
  clang/lib/Format/TemplateArgumentKeywordFixer.h
  clang/unittests/Format/CMakeLists.txt
  clang/unittests/Format/TemplateArgumentKeywordFixerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116290.396361.patch
Type: text/x-patch
Size: 25119 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211228/a8ecc2df/attachment-0001.bin>


More information about the cfe-commits mailing list