[clang] 0c9a4da - [ASTMatchers] Simplify string comparisons (NFC)

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 27 15:32:57 PST 2021


Author: Kazu Hirata
Date: 2021-12-27T15:32:51-08:00
New Revision: 0c9a4da497c44d2c88b22ee52868fe37359c7a76

URL: https://github.com/llvm/llvm-project/commit/0c9a4da497c44d2c88b22ee52868fe37359c7a76
DIFF: https://github.com/llvm/llvm-project/commit/0c9a4da497c44d2c88b22ee52868fe37359c7a76.diff

LOG: [ASTMatchers] Simplify string comparisons (NFC)

Identified with readability-string-compare.

Added: 
    

Modified: 
    clang/include/clang/ASTMatchers/ASTMatchers.h

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/ASTMatchers/ASTMatchers.h b/clang/include/clang/ASTMatchers/ASTMatchers.h
index 55cce324b4362..599ab407c442b 100644
--- a/clang/include/clang/ASTMatchers/ASTMatchers.h
+++ b/clang/include/clang/ASTMatchers/ASTMatchers.h
@@ -3725,10 +3725,9 @@ AST_MATCHER_P(ObjCMessageExpr, hasReceiver, internal::Matcher<Expr>,
 /// \endcode
 AST_MATCHER_P(ObjCMessageExpr, hasSelector, std::string, BaseName) {
   Selector Sel = Node.getSelector();
-  return BaseName.compare(Sel.getAsString()) == 0;
+  return BaseName == Sel.getAsString();
 }
 
-
 /// Matches when at least one of the supplied string equals to the
 /// Selector.getAsString()
 ///


        


More information about the cfe-commits mailing list