[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

[Zixuan Wu via Phabricator via cfe-commits]

zixuan-wu added inline comments.


================
Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:33
+  bool operator!=(const RISCVExtensionVersion &Version) const {
+    return !operator==(Version);
+  }
----------------
craig.topper wrote:
> Use `!(*this == Version)`
Good taste.


================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:91
                                                 StringRef ABIName) {
+  initializeEnvironment();
   // Determine default and user-specified characteristics
----------------
craig.topper wrote:
> Why do we need to initialize things now but didn't before?
After the constructor is workable to initialize, no need for initializeEnvironment. So remove it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115921/new/

https://reviews.llvm.org/D115921