[PATCH] D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers

gehry via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 24 02:05:25 PST 2021


Sockke requested changes to this revision.
Sockke added a comment.
This revision now requires changes to proceed.

Could you please add a test case where the smart pointer object is dereferenced before calling `size()`? E.g. `return (*ptr).size() == 0;`. I think this change doesn't work on this test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115124/new/

https://reviews.llvm.org/D115124



More information about the cfe-commits mailing list