[PATCH] D116098: [C++20] [Modules] Mark imported module as imported if not exported

Nathan Sidwell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 23 03:52:52 PST 2021


urnathan added a comment.

as all exports are also imports, is there a reason we don;t also add the exports into the import table?  is Exports really 'ExportedImports' and 'Imports'  really 'NotExportedImports'?  If that's the case, this patch is fine.



================
Comment at: clang/lib/Sema/SemaModule.cpp:386
 
   // Re-export the module if needed.
   if (!ModuleScopes.empty() && ModuleScopes.back().ModuleInterface) {
----------------
This comment will need adjusting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116098/new/

https://reviews.llvm.org/D116098



More information about the cfe-commits mailing list