[PATCH] D115103: Leak Sanitizer port to Windows
Vitaly Buka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 22 16:26:44 PST 2021
vitalybuka added a comment.
In D115103#3207210 <https://reviews.llvm.org/D115103#3207210>, @clemenswasser wrote:
> The problem is, that `LSAN_BASE` is not always `use_stacks=0:use_registers=0`.
Off-cause , I am asking to replace with correct value each test.
> Also there are many test cases, where `LSAN_BASE` gets used multiple times.
> Removing it would result in bad repetition.
I don't like LSAN_BASE even without Windows.
Usually when test fail, I have a single command line to reproduce or put into debugger for just the step. Here I need to cherry-pick two line: LSAN_BASE= and actual step
also in most case it used just twice, so it's not a big loss in repetition
CHANGES SINCE LAST ACTION
More information about the cfe-commits