[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version
Luís Marques via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 22 05:25:27 PST 2021
luismarques added a comment.
I think this would benefit from increased test coverage, namely to show that the mattr command-line options are properly handled. Some possible ideas:
- Tests with the correct extension versions (maybe add a test file that exercises the version for all extensions).
- Tests that show an error message with unsupported versions.
- A test that shows that something like mattr=+m,+m2p1 is allowed (or not).
Nit: fix the lint / no new line warnings.
CHANGES SINCE LAST ACTION
More information about the cfe-commits