[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

Ella Ma via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 21 19:00:54 PST 2021

OikawaKirie added a comment.

In D102669#3199270 <https://reviews.llvm.org/D102669#3199270>, @steakhal wrote:

> We shouldn't skip mac targets. I CC ASTImporter folks, they probably have an M1 <https://reviews.llvm.org/M1>.

I am not intended to ignore this problem triggered on M1 <https://reviews.llvm.org/M1>. However, I think it is not this patch that leads to this problem, it just triggers it.
I mean we can just disable the test case temporarily on M1 <https://reviews.llvm.org/M1>, and fix this problem as well as enable this patch and the one of on-demand-parsing in another patch.
I think they trigger the same problem for the same reason on M1 <https://reviews.llvm.org/M1>.

Besides, it seems to be the problem of `ASTUnit::LoadFromCommandLine`, rather than the ASTImporter.

Comment at: clang/test/Analysis/ctu-lookup-name-with-space.cpp:13
+// RUN:   -verify %s
+void importee();
arichardson wrote:
> OikawaKirie wrote:
> > Adding this line here.
> Disabling the test on non- Linux is not a good idea IMO since it means we lose coverage on other platforms. My guess is that you just need to specify an explicit triple in the clang invocations.
AFAIK, we cannot do that. If this test case is executed on different platforms, we cannot determine the triple ahead of time and specify it in the invocation list.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list