[PATCH] D109885: [MLIR][[amdgpu-arch]][OpenMP] Remove direct dependency on /opt/rocm

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 20 12:43:33 PST 2021


JonChesterfield added a comment.

In D109885#3203412 <https://reviews.llvm.org/D109885#3203412>, @arsenm wrote:

> We should have versioned libraries and well defined ABI breaks. The build should know what runtime versions it requires and account when searching

If we're playing that game, ROCm should be strictly an extension of upstream LLVM, such that code which accidentally or intentionally picks up parts of ROCm while expecting parts of trunk runs correctly. I'd be happy with the easier objective of making it difficult to accidentally splice together parts of different toolchains at runtime.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109885/new/

https://reviews.llvm.org/D109885



More information about the cfe-commits mailing list