[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

[Kadir Çetinkaya via cfe-commits]

Hi Salman, it looks like patch doesn't have edit access for anyone but you.
I had drafted some comments but can't hit the submit button.
I think you can go to
https://reviews.llvm.org/differential/revision/edit/116085/ and change the
`Editable By` field to `All Users`

On Tue, Dec 21, 2021 at 8:45 AM Salman Javed via Phabricator <
reviews at reviews.llvm.org> wrote:

> salman-javed-nz updated this revision to Diff 395606.
> salman-javed-nz added a comment.
>
> Remove unnecessary `llvm::` qualification.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D116085/new/
>
> https://reviews.llvm.org/D116085
>
> Files:
>   clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
>   clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h
>   clang-tools-extra/test/clang-tidy/infrastructure/nolint.cpp
>   clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-LIFO.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-all-end-glob.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-all-end-specific.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-glob-end-all.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-glob-end-specific.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-global-end-specific.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-multiple-end-single.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-single-end-multiple.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-specific-end-all.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-specific-end-glob.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-begin-specific-end-global.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-mismatched-check-names.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-mismatched-delims.cpp
>
> clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend-typo-in-check-name.cpp
>   clang-tools-extra/test/clang-tidy/infrastructure/nolintbeginend.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211221/7603d9a8/attachment.html>