[PATCH] D116059: [Clang][CFG] check children statements of asm goto

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 20 15:44:14 PST 2021


nickdesaulniers planned changes to this revision.
nickdesaulniers added inline comments.


================
Comment at: clang/lib/Analysis/CFG.cpp:3359
+
+  return VisitStmt(G, asc);
 }
----------------
I think this should actually be `return VisitChildren(G);`; it produces a simpler CFG with the `asm goto` Node marked as the terminator directly. Will update this and the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116059/new/

https://reviews.llvm.org/D116059



More information about the cfe-commits mailing list