[PATCH] D116043: [clangd] Don't trim xrefs references if we overran the limit

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 20 08:11:45 PST 2021


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1388
+      TargetsInMainFile.insert(ID);
+      // Not all symbols can be referenced from outside (e.g. function-locals).
+      // TODO: we could skip TU-scoped symbols here (e.g. static functions) if
----------------
This is a nice optimization.
Mention it in the patch description?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116043/new/

https://reviews.llvm.org/D116043



More information about the cfe-commits mailing list