[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 20 02:24:11 PST 2021


owenpan added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2005
-      }
-      break;
     case tok::l_square:
----------------
MyDeveloperDay wrote:
> Is this case not covered by this? I presume not as you didn't remove any unit tests
> 
> https://github.com/llvm/llvm-project/commit/516e054c05fcf92b89fbac3e22048f2c00cf218f
> 
> ```
> void f() {
>    int i = {[operation setCompletionBlock : ^{
>      [self onOperationDone];
>    }] };
>  }
> ```
I had checked the commit you mentioned above before I decided to remove this `case`. Apparently it's redundant to the caret `case` in `parseStructuralElement()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115967/new/

https://reviews.llvm.org/D115967



More information about the cfe-commits mailing list