[PATCH] D115640: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

Anton Zabaznov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 20 01:22:51 PST 2021

azabaznov marked 3 inline comments as done.
azabaznov added inline comments.

Comment at: clang/test/SemaOpenCL/invalid-device-enqueue-types-cl3.0.cl:5
+void f() {
+  clk_event_t e;
+  queue_t q;
Anastasia wrote:
> I know that many test have prefix "invalid" but I feel we have failed to establish the meaning for it because most of the tests in Sema are testing some sort of invalid behavior. But also here I feel that we should test that `enqueue_kernel` is not supported?
> Do you think we chould merge this testing together with `SemaOpenCL/cl20-device-side-enqueue.cl` with some filename renaming?
> Technically we should do the same testing even for CL1.x versions...
I think it can. But `enqueu_kernel` is a `LangBuiltin` and still not supported yet. Support for `LangBuiltins`  is going to be added in a separate patch: with this patch all of the features that affect language built-ins are supported.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list