[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h
Marek Kurdej via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Dec 19 12:32:58 PST 2021
curdeius added a comment.
Please review the descriptions.
Looks good, but I'm wondering if there are better names for these options.
E.g. when `AlignConsecutiveMacrosIgnoreMax` is true, then `AlignConsecutiveMacrosMinWidth` is not minimum width, but required/fixed width except for long macro names.
================
Comment at: clang/docs/ClangFormatStyleOptions.rst:547-550
+ Macros beyond ``AlignConsecutiveMacrosMinWidth`` break the
+ ConsecutiveMacroAlignment streak, When used in conjuction
+ With ``AlignConsecutiveMacrosMinWidth`` this allows longer macros to
+ not cause shorter macros to align.
----------------
Please add full stops at the end of sentences and fix capitals (like in With). (in Format.h of course and regenerate)
Commenting here as it's easier to see the end result.
Please check descriptions of other options too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112019/new/
https://reviews.llvm.org/D112019
More information about the cfe-commits
mailing list