[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 17 09:13:20 PST 2021


steakhal updated this revision to Diff 395150.
steakhal added a comment.

Sorry for the late update, but here we are:

Now, I properly handle all kinds of `NestedNameSpecifiers`.
Basically, I verify if the decls are matching, then I use the nested name specifiers for finding mismatches. I look through namespace aliases and I use the canonical types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114622/new/

https://reviews.llvm.org/D114622

Files:
  clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
  clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
  clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp
  clang/lib/StaticAnalyzer/Checkers/IdenticalExprChecker.cpp
  clang/test/Analysis/identical-expressions.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114622.395150.patch
Type: text/x-patch
Size: 14623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211217/5d5e71db/attachment-0001.bin>


More information about the cfe-commits mailing list