[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

Peter Stys via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 17 07:49:15 PST 2021


peterstys added a comment.

In D115738#3199896 <https://reviews.llvm.org/D115738#3199896>, @MyDeveloperDay wrote:

> In D115738#3199879 <https://reviews.llvm.org/D115738#3199879>, @peterstys wrote:
>
>> This is my first PR into this repo. I'd like to learn more about the process of submitting patches, specifically about:
>>
>> - Do I need to get LGTM from all the reviewers before I can submit it?
>
>
>
>   No, one is likely enough, but employ some level of respect for others if they are commenting (they may not explicitly say LGTM but may accept) 
>
>> - There are some build failures on the CI, but look unrelated, do I force submit passed them?
>
>
>
>   They CI doesn't block commit. just check to ensure its not you, (there is some odd Go issue ATM which I've seen reported elsewhere)
>
>> Could someone help me with these questions or point me to the relevant documentation. Thanks.
>
> https://llvm.org/docs/Contributing.html
> https://llvm.org/docs/Phabricator.html

Great. Thank you. Very helpful.

Regarding failing CI: it seems that the LLVM_ALL_PROJECTS in CMakeLists.txt miss "bolt" setting (line 67): set(LLVM_ALL_PROJECTS "clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;libcxx;libcxxabi;libunwind;lld;lldb;mlir;openmp;polly;pstl")

Regarding committing the change: I won't have commit rights. Could someone do it for me?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115738/new/

https://reviews.llvm.org/D115738



More information about the cfe-commits mailing list